From e1f3ff0d08584b95de2417ed86d6b5ad00b05008 Mon Sep 17 00:00:00 2001 From: Amaury Denoyelle Date: Mon, 6 Dec 2021 14:26:52 +0100 Subject: [PATCH] MINOR: h3: add BUG_ON on control receive function Add BUG_ON statement when handling a non implemented frames on the control stream. This is required because frames must be removed from the RX buffer or else it will stall the buffer. --- src/h3.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/src/h3.c b/src/h3.c index 9be2a5b11c..14c56c697e 100644 --- a/src/h3.c +++ b/src/h3.c @@ -299,14 +299,20 @@ static int h3_control_recv(struct h3_uqs *h3_uqs, void *ctx) /* From here, a frame must not be truncated */ switch (ftype) { case H3_FT_CANCEL_PUSH: + /* XXX TODO XXX */ + ABORT_NOW(); break; case H3_FT_SETTINGS: if (!h3_parse_settings_frm(h3, rxbuf, flen)) return 0; break; case H3_FT_GOAWAY: + /* XXX TODO XXX */ + ABORT_NOW(); break; case H3_FT_MAX_PUSH_ID: + /* XXX TODO XXX */ + ABORT_NOW(); break; default: /* Error */ -- 2.47.3