From e28f3e9985a592ba6e2ca693050669700520d3be Mon Sep 17 00:00:00 2001 From: Amos Jeffries Date: Tue, 24 Nov 2009 15:36:29 +1300 Subject: [PATCH] Fix detection of obsolete 'all' patterns A little bit overly enthusiastic on the additions... * 0.0.0.0 is a /32 not /0 * 0->N is 'all', not 0->0 --- src/acl/Ip.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/acl/Ip.cc b/src/acl/Ip.cc index bc9bbba848..982293be44 100644 --- a/src/acl/Ip.cc +++ b/src/acl/Ip.cc @@ -277,7 +277,7 @@ acl_ip_data::FactoryParse(const char *t) /* Detect some old broken strings equivalent to 'all'. * treat them nicely. But be loud until its fixed. */ if (strcasecmp(t, "0/0") == 0 || strcasecmp(t, "0.0.0.0/0") == 0 || strcasecmp(t, "0.0.0.0/0.0.0.0") == 0 || - strcasecmp(t, "0.0.0.0") == 0 || strcasecmp(t, "0.0.0.0-0.0.0.0") == 0 || strcasecmp(t, "0.0.0.0-0.0.0.0/0") == 0) { + strcasecmp(t, "0.0.0.0-255.255.255.255") == 0 || strcasecmp(t, "0.0.0.0-0.0.0.0/0") == 0) { debugs(28,DBG_CRITICAL, "ERROR: '" << t << "' needs to be replaced by the term 'all'."); debugs(28,DBG_CRITICAL, "SECURITY NOTICE: Overriding config setting. Using 'all' instead."); -- 2.47.3