From e3970f6227fa774f2915f5e7e6a024dcbc75983e Mon Sep 17 00:00:00 2001 From: James Coglan Date: Wed, 29 May 2024 10:56:29 +0100 Subject: [PATCH] resolved: tests for dns_resource_key_equal() and dns_resource_key_match_rr() --- src/resolve/test-dns-rr.c | 209 ++++++++++++++++++++++++++++++++++++++ 1 file changed, 209 insertions(+) diff --git a/src/resolve/test-dns-rr.c b/src/resolve/test-dns-rr.c index 737968916b1..9ca0c2c6d6c 100644 --- a/src/resolve/test-dns-rr.c +++ b/src/resolve/test-dns-rr.c @@ -266,4 +266,213 @@ TEST(dns_resource_key_is_dnssd_two_label_ptr) { dns_resource_key_unref(key); } +/* ================================================================ + * dns_resource_key_equal() + * ================================================================ */ + +TEST(dns_resource_key_equal_same_pointer) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *a = NULL; + + a = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(a); + + ASSERT_TRUE(dns_resource_key_equal(a, a)); +} + +TEST(dns_resource_key_equal_equal_name) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *a = NULL, *b = NULL; + + a = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(a); + + b = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(b); + + ASSERT_TRUE(dns_resource_key_equal(a, b)); +} + +TEST(dns_resource_key_equal_case_insensitive_name) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *a = NULL, *b = NULL; + + a = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(a); + + b = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.EXAMPLE.com"); + ASSERT_NOT_NULL(b); + + ASSERT_TRUE(dns_resource_key_equal(a, b)); +} + +TEST(dns_resource_key_equal_trailing_dot) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *a = NULL, *b = NULL; + + a = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(a); + + b = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com."); + ASSERT_NOT_NULL(b); + + ASSERT_TRUE(dns_resource_key_equal(a, b)); +} + +TEST(dns_resource_key_equal_different_names) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *a = NULL, *b = NULL; + + a = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(a); + + b = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.org"); + ASSERT_NOT_NULL(b); + + ASSERT_FALSE(dns_resource_key_equal(a, b)); +} + +TEST(dns_resource_key_equal_different_classes) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *a = NULL, *b = NULL; + + a = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(a); + + b = dns_resource_key_new(DNS_CLASS_ANY, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(b); + + ASSERT_FALSE(dns_resource_key_equal(a, b)); +} + +TEST(dns_resource_key_equal_different_types) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *a = NULL, *b = NULL; + + a = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(a); + + b = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_AAAA, "www.example.com"); + ASSERT_NOT_NULL(b); + + ASSERT_FALSE(dns_resource_key_equal(a, b)); +} + +/* ================================================================ + * dns_resource_key_match_rr() + * ================================================================ */ + +TEST(dns_resource_key_match_rr_simple) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(key); + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(rr); + + ASSERT_TRUE(dns_resource_key_match_rr(key, rr, NULL)); +} + +TEST(dns_resource_key_match_rr_any_class) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + key = dns_resource_key_new(DNS_CLASS_ANY, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(key); + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(rr); + + ASSERT_TRUE(dns_resource_key_match_rr(key, rr, NULL)); +} + +TEST(dns_resource_key_match_rr_any_type) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_ANY, "www.example.com"); + ASSERT_NOT_NULL(key); + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(rr); + + ASSERT_TRUE(dns_resource_key_match_rr(key, rr, NULL)); +} + +TEST(dns_resource_key_match_rr_different_type) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(key); + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_AAAA, "www.example.com"); + ASSERT_NOT_NULL(rr); + + ASSERT_FALSE(dns_resource_key_match_rr(key, rr, NULL)); +} + +TEST(dns_resource_key_match_rr_different_name) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.other.com"); + ASSERT_NOT_NULL(key); + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(rr); + + ASSERT_FALSE(dns_resource_key_match_rr(key, rr, NULL)); +} + +TEST(dns_resource_key_match_rr_case_insensitive_name) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.EXAMPLE.com"); + ASSERT_NOT_NULL(key); + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(rr); + + ASSERT_TRUE(dns_resource_key_match_rr(key, rr, NULL)); +} + +TEST(dns_resource_key_match_rr_escape_error) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.\\example.com"); + ASSERT_NOT_NULL(key); + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(rr); + + ASSERT_ERROR(dns_resource_key_match_rr(key, rr, NULL), EINVAL); +} + +TEST(dns_resource_key_match_rr_search_domain) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example"); + ASSERT_NOT_NULL(key); + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(rr); + + ASSERT_TRUE(dns_resource_key_match_rr(key, rr, "com")); +} + +TEST(dns_resource_key_match_rr_no_search_domain) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example"); + ASSERT_NOT_NULL(key); + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(rr); + + ASSERT_FALSE(dns_resource_key_match_rr(key, rr, NULL)); +} + +TEST(dns_resource_key_match_rr_different_search_domain) { + _cleanup_(dns_resource_key_unrefp) DnsResourceKey *key = NULL; + _cleanup_(dns_resource_record_unrefp) DnsResourceRecord *rr = NULL; + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example"); + ASSERT_NOT_NULL(key); + rr = dns_resource_record_new_full(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(rr); + + ASSERT_FALSE(dns_resource_key_match_rr(key, rr, "org")); +} + DEFINE_TEST_MAIN(LOG_DEBUG); -- 2.47.3