From e3d15db0308b37d0097de3a8462a1897f86db998 Mon Sep 17 00:00:00 2001 From: Aurelien Aptel Date: Fri, 5 Feb 2016 15:29:28 +0100 Subject: [PATCH] pidl/ws: fix Assigned value is garbage or undefined found by Clang Analyzer Port Wireshark commit 683d657 Author: Alexis La Goutte Date: Sun Oct 5 19:27:15 2014 +0200 PIDL (DCERPC): fix Assigned value is garbage or undefined found by Clang Analyzer packet-dcerpc-dnsserver.c:1002:12: warning: Assigned value is garbage or undefined packet-dcerpc-frstrans.c:1137:12: warning: Assigned value is garbage or undefined packet-dcerpc-lsa.c:6345:12: warning: Assigned value is garbage or undefined packet-dcerpc-nspi.c:7805:12: warning: Assigned value is garbage or undefined packet-dcerpc-dfs.c:3245:11: warning: Function call argument is an uninitialized value packet-dcerpc-dfs.c:3245:9: warning: 'level' may be used uninitialized in this function [-Wmaybe-uninitialized] Change-Id: Ife6a2f565ae215535d0e3d72ef50800114240e3f Reviewed-on: https://code.wireshark.org/review/4478 Reviewed-by: Evan Huus Signed-off-by: Aurelien Aptel Reviewed-by: Stefan Metzmacher Reviewed-by: David Disseldorp --- pidl/lib/Parse/Pidl/Wireshark/NDR.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pidl/lib/Parse/Pidl/Wireshark/NDR.pm b/pidl/lib/Parse/Pidl/Wireshark/NDR.pm index 40c59c9a517..632f0942dd2 100644 --- a/pidl/lib/Parse/Pidl/Wireshark/NDR.pm +++ b/pidl/lib/Parse/Pidl/Wireshark/NDR.pm @@ -661,7 +661,7 @@ sub Struct($$$$) } my $switch_type = "g${switch_raw_type}"; - push @$vars, "$switch_type $v;"; + push @$vars, "$switch_type $v = 0;"; $switch_info = [ $_->{TYPE}, $v ]; $varswitchs->{$v} = $switch_info; } -- 2.47.3