From e41276120685f5e01dd5dae1aa72faa286698b9f Mon Sep 17 00:00:00 2001 From: Peter Krempa Date: Mon, 20 Oct 2025 15:16:48 +0200 Subject: [PATCH] virNetDevVlanParse: Use g_autofree for temporary variables Automatically free the variables to prevent leaks when returning from middle of the function. Fixes: 1de6fd5edb5 Closes: https://gitlab.com/libvirt/libvirt/-/issues/824 Signed-off-by: Peter Krempa Reviewed-by: Michal Privoznik --- src/conf/netdev_vlan_conf.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/conf/netdev_vlan_conf.c b/src/conf/netdev_vlan_conf.c index b98c4d92cf..012a28034e 100644 --- a/src/conf/netdev_vlan_conf.c +++ b/src/conf/netdev_vlan_conf.c @@ -34,8 +34,8 @@ virNetDevVlanParse(xmlNodePtr node, xmlXPathContextPtr ctxt, virNetDevVlan *def) { int ret = -1; VIR_XPATH_NODE_AUTORESTORE(ctxt) - char *trunk = NULL; - xmlNodePtr *tagNodes = NULL; + g_autofree char *trunk = NULL; + g_autofree xmlNodePtr *tagNodes = NULL; int nTags; size_t i; @@ -120,8 +120,6 @@ virNetDevVlanParse(xmlNodePtr node, xmlXPathContextPtr ctxt, virNetDevVlan *def) ret = 0; cleanup: - VIR_FREE(tagNodes); - VIR_FREE(trunk); return ret; } -- 2.47.3