From e8139f3b378568c065da1a082db73352da64b289 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fr=C3=A9d=C3=A9ric=20L=C3=A9caille?= Date: Thu, 11 Mar 2021 17:06:30 +0100 Subject: [PATCH] BUG/MINOR: quic: Wrong ->accept() error handling Really signal the caller that ->accept() has failed if the session could not be initialized because conn_complete_session() has failed. This is the case if the mux could not be initialized too. When it fails an ->accept() must returns -1 in case of resource shortage. --- src/quic_sock.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/src/quic_sock.c b/src/quic_sock.c index 1a5cf69df2..011b93ad6d 100644 --- a/src/quic_sock.c +++ b/src/quic_sock.c @@ -69,8 +69,6 @@ int quic_session_accept(struct connection *cli_conn) if (conn_complete_session(cli_conn) >= 0) return 1; - return 0; - out_free_sess: /* prevent call to listener_release during session_free. It will be * done below, for all errors. */ @@ -83,7 +81,7 @@ int quic_session_accept(struct connection *cli_conn) conn_free(cli_conn); out: - return 0; + return -1; } /* -- 2.47.3