From ea1627008e2ccca3eefa8f4f8123ad74d34c7500 Mon Sep 17 00:00:00 2001 From: "Miss Islington (bot)" <31488909+miss-islington@users.noreply.github.com> Date: Sun, 10 Mar 2019 17:37:36 -0700 Subject: [PATCH] bpo-36176: Fix IDLE autocomplete & calltip popup colors. (GH-12262) Prevent conflicts with Linux dark themes (and slightly darken calltip background). (cherry picked from commit 491ef53c1548c2b593d3c35d1e7bf25ccb443019) Co-authored-by: Terry Jan Reedy --- Lib/idlelib/NEWS.txt | 6 +++++- Lib/idlelib/autocomplete_w.py | 2 +- Lib/idlelib/calltip_w.py | 3 ++- .../next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst | 2 ++ 4 files changed, 10 insertions(+), 3 deletions(-) create mode 100644 Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst diff --git a/Lib/idlelib/NEWS.txt b/Lib/idlelib/NEWS.txt index d2c150b8e2a9..c343538a29c2 100644 --- a/Lib/idlelib/NEWS.txt +++ b/Lib/idlelib/NEWS.txt @@ -3,7 +3,11 @@ Released on 2019-??-?? ====================================== -bpl-36152: Remove colorizer.ColorDelegator.close_when_done and the +bpo-36176: Fix IDLE autocomplete & calltip popup colors. +Prevent conflicts with Linux dark themes +(and slightly darken calltip background). + +bpo-36152: Remove colorizer.ColorDelegator.close_when_done and the corresponding argument of .close(). In IDLE, both have always been None or False since 2007. diff --git a/Lib/idlelib/autocomplete_w.py b/Lib/idlelib/autocomplete_w.py index 7994bc0db170..c24962527736 100644 --- a/Lib/idlelib/autocomplete_w.py +++ b/Lib/idlelib/autocomplete_w.py @@ -189,7 +189,7 @@ class AutoCompleteWindow: pass self.scrollbar = scrollbar = Scrollbar(acw, orient=VERTICAL) self.listbox = listbox = Listbox(acw, yscrollcommand=scrollbar.set, - exportselection=False, bg="white") + exportselection=False) for item in self.completions: listbox.insert(END, item) self.origselforeground = listbox.cget("selectforeground") diff --git a/Lib/idlelib/calltip_w.py b/Lib/idlelib/calltip_w.py index 7553dfefc55c..1e0404aa49f5 100644 --- a/Lib/idlelib/calltip_w.py +++ b/Lib/idlelib/calltip_w.py @@ -80,7 +80,8 @@ class CalltipWindow(TooltipBase): def showcontents(self): """Create the call-tip widget.""" self.label = Label(self.tipwindow, text=self.text, justify=LEFT, - background="#ffffe0", relief=SOLID, borderwidth=1, + background="#ffffd0", foreground="black", + relief=SOLID, borderwidth=1, font=self.anchor_widget['font']) self.label.pack() diff --git a/Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst b/Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst new file mode 100644 index 000000000000..5998c6fadfc7 --- /dev/null +++ b/Misc/NEWS.d/next/IDLE/2019-03-10-00-07-46.bpo-36176.jk_vv6.rst @@ -0,0 +1,2 @@ +Fix IDLE autocomplete & calltip popup colors. Prevent conflicts with Linux +dark themes (and slightly darken calltip background). -- 2.47.3