From ef96814ea0b7ebec1e4d6e9045b3db83c9f755a8 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Tue, 22 Apr 2025 10:58:07 +0200 Subject: [PATCH] 5.10-stable patches added patches: nvmet-fc-remove-unused-functions.patch --- .../nvmet-fc-remove-unused-functions.patch | 64 +++++++++++++++++++ queue-5.10/series | 1 + 2 files changed, 65 insertions(+) create mode 100644 queue-5.10/nvmet-fc-remove-unused-functions.patch diff --git a/queue-5.10/nvmet-fc-remove-unused-functions.patch b/queue-5.10/nvmet-fc-remove-unused-functions.patch new file mode 100644 index 0000000000..e01838c9e0 --- /dev/null +++ b/queue-5.10/nvmet-fc-remove-unused-functions.patch @@ -0,0 +1,64 @@ +From 1b304c006b0fb4f0517a8c4ba8c46e88f48a069c Mon Sep 17 00:00:00 2001 +From: WangYuli +Date: Wed, 12 Mar 2025 13:06:50 +0800 +Subject: nvmet-fc: Remove unused functions + +From: WangYuli + +commit 1b304c006b0fb4f0517a8c4ba8c46e88f48a069c upstream. + +The functions nvmet_fc_iodnum() and nvmet_fc_fodnum() are currently +unutilized. + +Following commit c53432030d86 ("nvme-fabrics: Add target support for FC +transport"), which introduced these two functions, they have not been +used at all in practice. + +Remove them to resolve the compiler warnings. + +Fix follow errors with clang-19 when W=1e: + drivers/nvme/target/fc.c:177:1: error: unused function 'nvmet_fc_iodnum' [-Werror,-Wunused-function] + 177 | nvmet_fc_iodnum(struct nvmet_fc_ls_iod *iodptr) + | ^~~~~~~~~~~~~~~ + drivers/nvme/target/fc.c:183:1: error: unused function 'nvmet_fc_fodnum' [-Werror,-Wunused-function] + 183 | nvmet_fc_fodnum(struct nvmet_fc_fcp_iod *fodptr) + | ^~~~~~~~~~~~~~~ + 2 errors generated. + make[8]: *** [scripts/Makefile.build:207: drivers/nvme/target/fc.o] Error 1 + make[7]: *** [scripts/Makefile.build:465: drivers/nvme/target] Error 2 + make[6]: *** [scripts/Makefile.build:465: drivers/nvme] Error 2 + make[6]: *** Waiting for unfinished jobs.... + +Fixes: c53432030d86 ("nvme-fabrics: Add target support for FC transport") +Signed-off-by: WangYuli +Reviewed-by: Chaitanya Kulkarni +Reviewed-by: Christoph Hellwig +Signed-off-by: Keith Busch +Signed-off-by: Greg Kroah-Hartman +--- + drivers/nvme/target/fc.c | 14 -------------- + 1 file changed, 14 deletions(-) + +--- a/drivers/nvme/target/fc.c ++++ b/drivers/nvme/target/fc.c +@@ -169,20 +169,6 @@ struct nvmet_fc_tgt_assoc { + struct work_struct del_work; + }; + +- +-static inline int +-nvmet_fc_iodnum(struct nvmet_fc_ls_iod *iodptr) +-{ +- return (iodptr - iodptr->tgtport->iod); +-} +- +-static inline int +-nvmet_fc_fodnum(struct nvmet_fc_fcp_iod *fodptr) +-{ +- return (fodptr - fodptr->queue->fod); +-} +- +- + /* + * Association and Connection IDs: + * diff --git a/queue-5.10/series b/queue-5.10/series index ca80894c31..1795fe7d90 100644 --- a/queue-5.10/series +++ b/queue-5.10/series @@ -155,3 +155,4 @@ phy-tegra-xusb-fix-return-value-of-tegra_xusb_find_port_node-function.patch wifi-ath10k-avoid-null-pointer-error-during-sdio-remove.patch drm-amd-display-stop-amdgpu_dm-initialize-when-link-nums-greater-than-max_links.patch drm-amd-display-fix-out-of-bounds-access-in-dcn21_link_encoder_create.patch +nvmet-fc-remove-unused-functions.patch -- 2.47.3