From f263a45ddf5dc57e6f68de0261bcb43a11d3f3aa Mon Sep 17 00:00:00 2001 From: Willy Tarreau Date: Thu, 16 Oct 2025 08:38:35 +0200 Subject: [PATCH] BUG/MINOR: pools: don't report "limited to the first X entries" by default With the fix in commit 982805e6a3 ("BUG/MINOR: pools: Fix the dump of pools info to deal with buffers limitations"), the max count is now compared to the number of dumped pools instead of the configured numbered, and keeping >= is no longer valid because maxcnt is set by default to the same value when not set, so this means that since this patch we're always displaying "limited to the first X entries" where X is the number of dumped entries even in the absence of any limitation. Let's just fix the comparison to only show this when the limit is lower. This must be backported to 3.2 where the patch above already is. --- src/pool.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/pool.c b/src/pool.c index 594195d10..9d247eb58 100644 --- a/src/pool.c +++ b/src/pool.c @@ -1399,7 +1399,7 @@ int dump_pools_info(struct appctx *appctx) if (ctx->pool_idx == -1) { chunk_printf(&trash, "Dumping pools usage"); - if (ctx->nbpools >= ctx->maxcnt) + if (ctx->nbpools > ctx->maxcnt) chunk_appendf(&trash, " (limited to the first %u entries)", ctx->maxcnt); chunk_appendf(&trash, ". Use SIGQUIT to flush them.\n"); -- 2.47.3