From f5ad1f25c35905013dc6997611cc87d497780267 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Fr=C3=A9d=C3=A9ric=20Buclin?= Date: Thu, 22 Apr 2010 20:16:44 +0200 Subject: [PATCH] Bug 561129: Various warnings thrown by Search.pm: Perl 5.12 complains for lc(undef) and uc(undef) r/a=mkanat --- Bugzilla/Search.pm | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/Bugzilla/Search.pm b/Bugzilla/Search.pm index 630cdd7d5a..d9f1d20397 100644 --- a/Bugzilla/Search.pm +++ b/Bugzilla/Search.pm @@ -388,8 +388,8 @@ sub init { } } - my $chfieldfrom = trim(lc($params->param('chfieldfrom'))) || ''; - my $chfieldto = trim(lc($params->param('chfieldto'))) || ''; + my $chfieldfrom = trim(lc($params->param('chfieldfrom') || '')); + my $chfieldto = trim(lc($params->param('chfieldto') || '')); $chfieldfrom = '' if ($chfieldfrom eq 'now'); $chfieldto = '' if ($chfieldto eq 'now'); my @chfield = $params->param('chfield'); @@ -1181,8 +1181,7 @@ sub BuildOrderBy { sub split_order_term { my $fragment = shift; $fragment =~ /^(.+?)(?:\s+(ASC|DESC))?$/i; - my ($column_name, $direction) = (lc($1), uc($2)); - $direction ||= ""; + my ($column_name, $direction) = (lc($1), uc($2 || '')); return wantarray ? ($column_name, $direction) : $column_name; } -- 2.47.3