From f5c26f7231e9c5558e40ef70529693a35a8442f2 Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Wed, 26 May 2021 13:44:15 +1200 Subject: [PATCH] samba_upgradedns: Create binddns_dir if it doesn't already exist Without doing this, the upgrade process can fail if the directory is not present, e.g. after restoring from an offline backup (which specifically ignores this directory). Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett Reviewed-by: Douglas Bagnall --- source4/scripting/bin/samba_upgradedns | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/source4/scripting/bin/samba_upgradedns b/source4/scripting/bin/samba_upgradedns index fc995648226..a3d515c0df3 100755 --- a/source4/scripting/bin/samba_upgradedns +++ b/source4/scripting/bin/samba_upgradedns @@ -492,6 +492,10 @@ if __name__ == '__main__': else: logger.info("dns-%s account already exists" % hostname) + if not os.path.exists(paths.binddns_dir): + # This directory won't exist if we're restoring from an offline backup. + os.mkdir(paths.binddns_dir, 0o770) + private_dns_keytab_path = os.path.join(paths.private_dir, paths.dns_keytab) bind_dns_keytab_path = os.path.join(paths.binddns_dir, paths.dns_keytab) -- 2.47.3