From f8ab983be947da2f47c40e3ae315b5daecb56e60 Mon Sep 17 00:00:00 2001 From: Greg Kroah-Hartman Date: Wed, 4 Oct 2023 19:10:22 +0200 Subject: [PATCH] 5.15-stable patches added patches: netfilter-nf_tables-fix-kdoc-warnings-after-gc-rework.patch --- ...es-fix-kdoc-warnings-after-gc-rework.patch | 47 +++++++++++++++++++ queue-5.15/series | 1 + 2 files changed, 48 insertions(+) create mode 100644 queue-5.15/netfilter-nf_tables-fix-kdoc-warnings-after-gc-rework.patch diff --git a/queue-5.15/netfilter-nf_tables-fix-kdoc-warnings-after-gc-rework.patch b/queue-5.15/netfilter-nf_tables-fix-kdoc-warnings-after-gc-rework.patch new file mode 100644 index 00000000000..0977db5c57e --- /dev/null +++ b/queue-5.15/netfilter-nf_tables-fix-kdoc-warnings-after-gc-rework.patch @@ -0,0 +1,47 @@ +From 08713cb006b6f07434f276c5ee214fb20c7fd965 Mon Sep 17 00:00:00 2001 +From: Florian Westphal +Date: Thu, 10 Aug 2023 23:59:03 +0200 +Subject: netfilter: nf_tables: fix kdoc warnings after gc rework + +From: Florian Westphal + +commit 08713cb006b6f07434f276c5ee214fb20c7fd965 upstream. + +Jakub Kicinski says: + We've got some new kdoc warnings here: + net/netfilter/nft_set_pipapo.c:1557: warning: Function parameter or member '_set' not described in 'pipapo_gc' + net/netfilter/nft_set_pipapo.c:1557: warning: Excess function parameter 'set' description in 'pipapo_gc' + include/net/netfilter/nf_tables.h:577: warning: Function parameter or member 'dead' not described in 'nft_set' + +Fixes: 5f68718b34a5 ("netfilter: nf_tables: GC transaction API to avoid race with control plane") +Fixes: f6c383b8c31a ("netfilter: nf_tables: adapt set backend to use GC transaction API") +Reported-by: Jakub Kicinski +Closes: https://lore.kernel.org/netdev/20230810104638.746e46f1@kernel.org/ +Signed-off-by: Florian Westphal +Signed-off-by: Greg Kroah-Hartman +--- + include/net/netfilter/nf_tables.h | 1 + + net/netfilter/nft_set_pipapo.c | 2 +- + 2 files changed, 2 insertions(+), 1 deletion(-) + +--- a/include/net/netfilter/nf_tables.h ++++ b/include/net/netfilter/nf_tables.h +@@ -499,6 +499,7 @@ struct nft_set_elem_expr { + * @expr: stateful expression + * @ops: set ops + * @flags: set flags ++ * @dead: set will be freed, never cleared + * @genmask: generation mask + * @klen: key length + * @dlen: data length +--- a/net/netfilter/nft_set_pipapo.c ++++ b/net/netfilter/nft_set_pipapo.c +@@ -1550,7 +1550,7 @@ static void nft_pipapo_gc_deactivate(str + + /** + * pipapo_gc() - Drop expired entries from set, destroy start and end elements +- * @set: nftables API set representation ++ * @_set: nftables API set representation + * @m: Matching data + */ + static void pipapo_gc(const struct nft_set *_set, struct nft_pipapo_match *m) diff --git a/queue-5.15/series b/queue-5.15/series index 710fcadc06f..bb81b5b18f7 100644 --- a/queue-5.15/series +++ b/queue-5.15/series @@ -180,3 +180,4 @@ ata-libata-core-do-not-register-pm-operations-for-sas-ports.patch ata-libata-sata-increase-pmp-srst-timeout-to-10s.patch fs-binfmt_elf_efpic-fix-personality-for-elf-fdpic.patch drm-meson-fix-memory-leak-on-hpd_notify-callback.patch +netfilter-nf_tables-fix-kdoc-warnings-after-gc-rework.patch -- 2.47.3