From fa25793ebff92bee2bb1bf0b437b5f705ee8a1dc Mon Sep 17 00:00:00 2001 From: Joseph Sutton Date: Tue, 31 Oct 2023 12:11:37 +1300 Subject: [PATCH] =?utf8?q?s4:rpc=5Fserver:=20Properly=20initialize=20?= =?utf8?q?=E2=80=98lsa=5FCreateTrustedDomainEx2=E2=80=99=20structure=20(CI?= =?utf8?q?D=201499407)?= MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit dcesrv_lsa_CreateTrustedDomain_base() invokes DCESRV_PULL_HANDLE(), which invokes DCESRV_PULL_HANDLE_RETVAL(), which invokes DCESRV_CHECK_HANDLE(), which might invoke DCESRV_FAULT(), which accesses r2.out.result, which is uninitialized — invoking undefined behaviour. Signed-off-by: Joseph Sutton Reviewed-by: Andrew Bartlett --- source4/rpc_server/lsa/dcesrv_lsa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/source4/rpc_server/lsa/dcesrv_lsa.c b/source4/rpc_server/lsa/dcesrv_lsa.c index 447789708f1..d1342747e88 100644 --- a/source4/rpc_server/lsa/dcesrv_lsa.c +++ b/source4/rpc_server/lsa/dcesrv_lsa.c @@ -1445,7 +1445,7 @@ static NTSTATUS dcesrv_lsa_CreateTrustedDomainEx(struct dcesrv_call_state *dce_c static NTSTATUS dcesrv_lsa_CreateTrustedDomain(struct dcesrv_call_state *dce_call, TALLOC_CTX *mem_ctx, struct lsa_CreateTrustedDomain *r) { - struct lsa_CreateTrustedDomainEx2 r2; + struct lsa_CreateTrustedDomainEx2 r2 = {}; r2.in.policy_handle = r->in.policy_handle; r2.in.info = talloc(mem_ctx, struct lsa_TrustDomainInfoInfoEx); -- 2.47.3