From fc838bd42a6ab36caf318c00766fec7dc0297ffb Mon Sep 17 00:00:00 2001 From: James Coglan Date: Mon, 10 Jun 2024 11:12:51 +0100 Subject: [PATCH] resolved: tests for basic usage of dns_packet_append_key() --- src/resolve/test-dns-packet-append.c | 68 ++++++++++++++++++++++++++++ 1 file changed, 68 insertions(+) diff --git a/src/resolve/test-dns-packet-append.c b/src/resolve/test-dns-packet-append.c index c0c6a046012..388b43868a0 100644 --- a/src/resolve/test-dns-packet-append.c +++ b/src/resolve/test-dns-packet-append.c @@ -139,4 +139,72 @@ TEST(packet_new_query_checking_disabled) { ASSERT_EQ(DNS_PACKET_CD(packet), 1); } +/* ================================================================ + * dns_packet_append_key() + * ================================================================ */ + +TEST(packet_append_key_single_a) { + _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL; + DnsResourceKey *key = NULL; + + ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX)); + ASSERT_NOT_NULL(packet); + + DNS_PACKET_ID(packet) = htobe16(42); + DNS_PACKET_HEADER(packet)->flags = htobe16(DNS_PACKET_MAKE_FLAGS(0, 0, 0, 0, 1, 0, 0, 0, DNS_RCODE_SUCCESS)); + DNS_PACKET_HEADER(packet)->qdcount = htobe16(1); + + key = dns_resource_key_new(DNS_CLASS_IN, DNS_TYPE_A, "www.example.com"); + ASSERT_NOT_NULL(key); + ASSERT_OK(dns_packet_append_key(packet, key, 0, NULL)); + dns_resource_key_unref(key); + + const uint8_t data[] = { + 0x00, 0x2a, BIT_RD, DNS_RCODE_SUCCESS, + 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + + /* name */ 0x03, 'w', 'w', 'w', + 0x07, 'e', 'x', 'a', 'm', 'p', 'l', 'e', + 0x03, 'c', 'o', 'm', + 0x00, + /* A */ 0x00, 0x01, + /* IN */ 0x00, 0x01 + }; + + ASSERT_EQ(packet->size, sizeof(data)); + ASSERT_EQ(memcmp(DNS_PACKET_DATA(packet), data, sizeof(data)), 0); +} + +TEST(packet_append_key_single_soa_any_class) { + _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL; + DnsResourceKey *key = NULL; + + ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX)); + ASSERT_NOT_NULL(packet); + + DNS_PACKET_ID(packet) = htobe16(42); + DNS_PACKET_HEADER(packet)->flags = htobe16(DNS_PACKET_MAKE_FLAGS(0, 0, 0, 0, 1, 0, 0, 0, DNS_RCODE_SUCCESS)); + DNS_PACKET_HEADER(packet)->qdcount = htobe16(1); + + key = dns_resource_key_new(DNS_CLASS_ANY, DNS_TYPE_SOA, "www.example.com"); + ASSERT_NOT_NULL(key); + ASSERT_OK(dns_packet_append_key(packet, key, 0, NULL)); + dns_resource_key_unref(key); + + const uint8_t data[] = { + 0x00, 0x2a, BIT_RD, DNS_RCODE_SUCCESS, + 0x00, 0x01, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, + + /* name */ 0x03, 'w', 'w', 'w', + 0x07, 'e', 'x', 'a', 'm', 'p', 'l', 'e', + 0x03, 'c', 'o', 'm', + 0x00, + /* SOA */ 0x00, 0x06, + /* ANY */ 0x00, 0xff + }; + + ASSERT_EQ(packet->size, sizeof(data)); + ASSERT_EQ(memcmp(DNS_PACKET_DATA(packet), data, sizeof(data)), 0); +} + DEFINE_TEST_MAIN(LOG_DEBUG) -- 2.47.3