From ff68db46ea6f6e693600bf24b22d9504fb82de03 Mon Sep 17 00:00:00 2001 From: terencez Date: Wed, 9 Oct 2019 23:55:57 +0800 Subject: [PATCH] fix(reactivity): avoid triggering effect when deleting property returns false (#168) --- packages/reactivity/src/baseHandlers.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/reactivity/src/baseHandlers.ts b/packages/reactivity/src/baseHandlers.ts index fe07600d9f..005cb3ddb8 100644 --- a/packages/reactivity/src/baseHandlers.ts +++ b/packages/reactivity/src/baseHandlers.ts @@ -70,7 +70,7 @@ function deleteProperty(target: any, key: string | symbol): boolean { const hadKey = hasOwn(target, key) const oldValue = target[key] const result = Reflect.deleteProperty(target, key) - if (hadKey) { + if (result && hadKey) { /* istanbul ignore else */ if (__DEV__) { trigger(target, OperationTypes.DELETE, key, { oldValue }) -- 2.47.3