From e00e2e0b50bbd120290572c8d1242703fb98b34e Mon Sep 17 00:00:00 2001 From: Frantisek Sumsal Date: Wed, 8 Apr 2020 12:12:46 +0200 Subject: [PATCH] test: wait a bit after stopping the test service Give systemd a chance to process the stop event before checking if the PID has indeed leaked. This should fix the intermittent test fails in CI even with a fixed systemd version, like this one: ``` Apr 08 10:22:09 testsuite-47.sh[345]: ++ cat /leakedtestpid Apr 08 10:22:09 testsuite-47.sh[334]: + leaked_pid=342 Apr 08 10:22:09 testsuite-47.sh[334]: + systemctl stop testsuite-47-repro Apr 08 10:22:10 testsuite-47.sh[334]: + ps -p 342 Apr 08 10:22:10 testsuite-47.sh[348]: PID TTY TIME CMD Apr 08 10:22:10 testsuite-47.sh[348]: 342 ? 00:00:00 sleep Apr 08 10:22:10 testsuite-47.sh[334]: + exit 42 ``` Followup to 197298ff9fc930de450330095cc5b67d165d0801 --- test/units/testsuite-47.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/test/units/testsuite-47.sh b/test/units/testsuite-47.sh index 09be780a680..97f86140f11 100755 --- a/test/units/testsuite-47.sh +++ b/test/units/testsuite-47.sh @@ -12,6 +12,7 @@ systemctl status testsuite-47-repro leaked_pid=$(cat /leakedtestpid) systemctl stop testsuite-47-repro +sleep 1 # Leaked PID will still be around if we're buggy. # I personally prefer to see 42. -- 2.47.3