From f2550b9856f9b89bc65e19754cb573c0a19ed1a0 Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 23 Feb 2021 15:43:19 +0100 Subject: [PATCH] core: fix memory leak in error path Coverity 1431998 --- src/core/execute.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/core/execute.c b/src/core/execute.c index d27adbbba54..e5c80fb183a 100644 --- a/src/core/execute.c +++ b/src/core/execute.c @@ -3202,11 +3202,16 @@ static int apply_mount_namespace( if (MANAGER_IS_SYSTEM(u->manager)) { propagate_dir = path_join("/run/systemd/propagate/", u->id); - if (!propagate_dir) - return -ENOMEM; + if (!propagate_dir) { + r = -ENOMEM; + goto finalize; + } + incoming_dir = strdup("/run/systemd/incoming"); - if (!incoming_dir) - return -ENOMEM; + if (!incoming_dir) { + r = -ENOMEM; + goto finalize; + } } r = setup_namespace(root_dir, root_image, context->root_image_options, -- 2.47.3