From b1e1e5ac255285aac2a26467df3a7b934a3f2000 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Thu, 8 Apr 2021 10:57:40 +0200 Subject: [PATCH] TEST-17: make the test test '! grep -v' does *not* test that there are no matching lines. Instead, it checks that whether there are any non-matching lines. And of course, for the test to fail, '! grep' cannot be part of an expression with &&. --- test/units/testsuite-17.04.sh | 57 +++++++++++++++-------------------- 1 file changed, 24 insertions(+), 33 deletions(-) diff --git a/test/units/testsuite-17.04.sh b/test/units/testsuite-17.04.sh index 428aa813322..b33d47ef6de 100755 --- a/test/units/testsuite-17.04.sh +++ b/test/units/testsuite-17.04.sh @@ -4,12 +4,9 @@ set -o pipefail mkdir -p /run/udev/rules.d/ -! test -f /run/udev/tags/added/c1:3 && - ! test -f /run/udev/tags/changed/c1:3 && - udevadm info /dev/null | grep -q -v 'E: TAGS=.*:added:.*' && - udevadm info /dev/null | grep -q -v 'E: CURRENT_TAGS=.*:added:.*' && - udevadm info /dev/null | grep -q -v 'E: TAGS=.*:changed:.*' && - udevadm info /dev/null | grep -q -v 'E: CURRENT_TAGS=.*:changed:.*' +test ! -f /run/udev/tags/added/c1:3 +test ! -f /run/udev/tags/changed/c1:3 +udevadm info /dev/null | grep -E 'E: (TAGS|CURRENT_TAGS)=.*:(added|changed):' && exit 1 cat >/run/udev/rules.d/50-testsuite.rules <