From 23ebdf4f8679b761261ef3190bb1e7e2f51d68c6 Mon Sep 17 00:00:00 2001 From: Yu Watanabe Date: Mon, 11 Apr 2022 00:02:17 +0900 Subject: [PATCH] udev: inline loop variable --- src/udev/udev-builtin.c | 19 +++++-------------- src/udev/udev-builtin.h | 2 +- 2 files changed, 6 insertions(+), 15 deletions(-) diff --git a/src/udev/udev-builtin.c b/src/udev/udev-builtin.c index a9095969bdc..bf827097719 100644 --- a/src/udev/udev-builtin.c +++ b/src/udev/udev-builtin.c @@ -32,12 +32,10 @@ static const UdevBuiltin *const builtins[_UDEV_BUILTIN_MAX] = { }; void udev_builtin_init(void) { - unsigned i; - if (initialized) return; - for (i = 0; i < _UDEV_BUILTIN_MAX; i++) + for (UdevBuiltinCommand i = 0; i < _UDEV_BUILTIN_MAX; i++) if (builtins[i] && builtins[i]->init) builtins[i]->init(); @@ -45,12 +43,10 @@ void udev_builtin_init(void) { } void udev_builtin_exit(void) { - unsigned i; - if (!initialized) return; - for (i = 0; i < _UDEV_BUILTIN_MAX; i++) + for (UdevBuiltinCommand i = 0; i < _UDEV_BUILTIN_MAX; i++) if (builtins[i] && builtins[i]->exit) builtins[i]->exit(); @@ -58,18 +54,14 @@ void udev_builtin_exit(void) { } bool udev_builtin_validate(void) { - unsigned i; - - for (i = 0; i < _UDEV_BUILTIN_MAX; i++) + for (UdevBuiltinCommand i = 0; i < _UDEV_BUILTIN_MAX; i++) if (builtins[i] && builtins[i]->validate && builtins[i]->validate()) return true; return false; } void udev_builtin_list(void) { - unsigned i; - - for (i = 0; i < _UDEV_BUILTIN_MAX; i++) + for (UdevBuiltinCommand i = 0; i < _UDEV_BUILTIN_MAX; i++) if (builtins[i]) fprintf(stderr, " %-14s %s\n", builtins[i]->name, builtins[i]->help); } @@ -93,14 +85,13 @@ bool udev_builtin_run_once(UdevBuiltinCommand cmd) { } UdevBuiltinCommand udev_builtin_lookup(const char *command) { - UdevBuiltinCommand i; size_t n; assert(command); command += strspn(command, WHITESPACE); n = strcspn(command, WHITESPACE); - for (i = 0; i < _UDEV_BUILTIN_MAX; i++) + for (UdevBuiltinCommand i = 0; i < _UDEV_BUILTIN_MAX; i++) if (builtins[i] && strneq(builtins[i]->name, command, n)) return i; diff --git a/src/udev/udev-builtin.h b/src/udev/udev-builtin.h index abfed2c181d..b0f2f919a9a 100644 --- a/src/udev/udev-builtin.h +++ b/src/udev/udev-builtin.h @@ -6,7 +6,7 @@ #include "sd-device.h" #include "sd-netlink.h" -typedef enum { +typedef enum UdevBuiltinCommand { #if HAVE_BLKID UDEV_BUILTIN_BLKID, #endif -- 2.47.3