From e1349c045eb1b3c179732b1db4804109ef282fca Mon Sep 17 00:00:00 2001 From: Lennart Poettering Date: Tue, 7 Mar 2023 12:21:10 +0100 Subject: [PATCH] mountpoint-util: add comment explaining why fstype_can_discard() can't use mount_option_supported() --- src/basic/mountpoint-util.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/basic/mountpoint-util.c b/src/basic/mountpoint-util.c index 2cb319ba649..e285702388a 100644 --- a/src/basic/mountpoint-util.c +++ b/src/basic/mountpoint-util.c @@ -509,9 +509,11 @@ bool fstype_can_umask(const char *fstype) { } bool fstype_can_uid_gid(const char *fstype) { - - /* All file systems that have a uid=/gid= mount option that fixates the owners of all files and directories, - * current and future. */ + /* All file systems that have a uid=/gid= mount option that fixates the owners of all files and + * directories, current and future. Note that this does *not* ask the kernel via + * mount_option_supported() here because the uid=/gid= setting of various file systems mean different + * things: some apply it only to the root dir inode, others to all inodes in the file system. Thus we + * maintain the curated list below. 😢 */ return STR_IN_SET(fstype, "adfs", -- 2.47.3