From 561eede4d126610ee5023098fc2787bd8864f144 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Zbigniew=20J=C4=99drzejewski-Szmek?= Date: Sun, 15 Jan 2017 20:25:35 -0500 Subject: [PATCH] coredump: add note about lack of rollback on oom --- src/coredump/coredump.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/coredump/coredump.c b/src/coredump/coredump.c index 7b11e230bfe..1bb1dbbe8d9 100644 --- a/src/coredump/coredump.c +++ b/src/coredump/coredump.c @@ -1049,7 +1049,9 @@ static int gather_pid_metadata( char **comm_fallback, char **comm_ret, struct iovec *iovec, size_t *n_iovec) { - /* We need 25 empty slots in iovec! */ + /* We need 25 empty slots in iovec! + * Note that if we fail on oom later on, we do not roll-back changes to the iovec + * structure. (It remains valid, with the first n_iovec fields initialized.) */ _cleanup_free_ char *exe = NULL, *comm = NULL; uid_t owner_uid; -- 2.47.3