]> git.ipfire.org Git - thirdparty/bind9.git/commit
Address theoretical resource leak in dns_dt_open()
authorMark Andrews <marka@isc.org>
Sun, 21 Feb 2021 22:44:56 +0000 (09:44 +1100)
committerMark Andrews <marka@isc.org>
Mon, 22 Feb 2021 01:22:31 +0000 (12:22 +1100)
commit003dd8cc700931509a6dfac4a4faab4084a2f085
treecebf6e9a628f2c66968eaa9cc83045bee67527d5
parentbb124d6056e5e8bc2a960ea9de914744803378bc
Address theoretical resource leak in dns_dt_open()

dns_dt_open() is not currently called with mode dns_dtmode_unix.

    *** CID 281489:  Resource leaks  (RESOURCE_LEAK)
    /lib/dns/dnstap.c: 983 in dns_dt_open()
    977
    978      if (!dnstap_file(handle->reader)) {
    979      CHECK(DNS_R_BADDNSTAP);
    980      }
    981      break;
    982      case dns_dtmode_unix:
       CID 281489:  Resource leaks  (RESOURCE_LEAK)
       Variable "handle" going out of scope leaks the storage it points to.
    983      return (ISC_R_NOTIMPLEMENTED);
    984      default:
    985      INSIST(0);
    986      ISC_UNREACHABLE();
    987      }
    988
lib/dns/dnstap.c