]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
pwm: jz4740: Don't use dev_err_probe() in .request()
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sat, 6 Jan 2024 14:13:03 +0000 (15:13 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 25 Jan 2024 23:27:42 +0000 (15:27 -0800)
commit00e29df1b44dfbeb06d2df9b7d8927ed1d00720c
treeca59fd578e304d9b9e7f4dcc04d0008c03bc243d
parenta372f1d01bc11aa85773a02353cd01aaf16dc18e
pwm: jz4740: Don't use dev_err_probe() in .request()

commit 9320fc509b87b4d795fb37112931e2f4f8b5c55f upstream.

dev_err_probe() is only supposed to be used in probe functions. While it
probably doesn't hurt, both the EPROBE_DEFER handling and calling
device_set_deferred_probe_reason() are conceptually wrong in the request
callback. So replace the call by dev_err() and a separate return
statement.

This effectively reverts commit c0bfe9606e03 ("pwm: jz4740: Simplify
with dev_err_probe()").

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://lore.kernel.org/r/20240106141302.1253365-2-u.kleine-koenig@pengutronix.de
Fixes: c0bfe9606e03 ("pwm: jz4740: Simplify with dev_err_probe()")
Cc: stable@vger.kernel.org
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/pwm/pwm-jz4740.c