]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
signal/arm64: Use force_sig not force_sig_fault for SIGKILL
authorEric W. Biederman <ebiederm@xmission.com>
Thu, 23 May 2019 16:11:19 +0000 (11:11 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 9 Jun 2019 07:16:14 +0000 (09:16 +0200)
commit013d8fcb191e7af39dc7d1062a46670c4f7dc461
treea220ab961230764053fcadac1dea85a308001c18
parent02ea8867ae63664c2b9d6c802db21a77bd03fdb0
signal/arm64: Use force_sig not force_sig_fault for SIGKILL

commit d76cac67db40c172791ce07948367b96a758e45b upstream.

I don't think this is userspace visible but SIGKILL does not have
any si_codes that use the fault member of the siginfo union.  Correct
this the simple way and call force_sig instead of force_sig_fault when
the signal is SIGKILL.

The two know places where synchronous SIGKILL are generated are
do_bad_area and fpsimd_save.  The call paths to force_sig_fault are:
do_bad_area
  arm64_force_sig_fault
    force_sig_fault
force_signal_inject
  arm64_notify_die
    arm64_force_sig_fault
       force_sig_fault

Which means correcting this in arm64_force_sig_fault is enough
to ensure the arm64 code is not misusing the generic code, which
could lead to maintenance problems later.

Cc: stable@vger.kernel.org
Cc: Dave Martin <Dave.Martin@arm.com>
Cc: James Morse <james.morse@arm.com>
Cc: Will Deacon <will.deacon@arm.com>
Fixes: af40ff687bc9 ("arm64: signal: Ensure si_code is valid for all fault signals")
Signed-off-by: "Eric W. Biederman" <ebiederm@xmission.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/arm64/kernel/traps.c