]> git.ipfire.org Git - thirdparty/bind9.git/commit
DoT: remove TLS-related kludge in isc__nmsocket_connecttimeout_cb()
authorArtem Boldariev <artem@boldariev.com>
Tue, 7 Mar 2023 21:16:11 +0000 (23:16 +0200)
committerArtem Boldariev <artem@boldariev.com>
Tue, 14 Mar 2023 16:49:29 +0000 (18:49 +0200)
commit034b5febb16d8547f60774271f70795a0e78de6f
treedd8d633bd2bb042402549384c757853d60992c05
parent03a73f720d44c3e4dd84a180bc019f89499500eb
DoT: remove TLS-related kludge in isc__nmsocket_connecttimeout_cb()

This commit ensures that 'sock->tls.pending_req' is not getting
nullified during TLS connection timeout callback as it prevents the
connection callback being called when connecting was not successful.

We expect 'isc__nm_failed_connect_cb() to be called from
'isc__nm_tlsdns_shutdown()' when establishing connections was
successful, but with 'sock->tls.pending_req' nullified that will not
happen.

The code removed most likely was required in older iterations of the
NM, but to me it seems that now it does only harm. One of the well
know pronounced effects is leading to irrecoverable zone transfer
hangs via TLS.
lib/isc/netmgr/netmgr.c