]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rtw88: fix potential NULL skb access in TX ISR
authorYan-Hsuan Chuang <yhchuang@realtek.com>
Tue, 7 Jan 2020 08:08:07 +0000 (16:08 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 24 Feb 2020 07:36:58 +0000 (08:36 +0100)
commit034c5f26d2bf646389d33ea43d7bb0491525b67c
tree5c4f75ef486c0ffb98baf66580151a02d3be30bf
parente7e4d0eaa639cafbb28c099d40a78e30aca1fb00
rtw88: fix potential NULL skb access in TX ISR

[ Upstream commit f4f84ff8377d4cedf18317747bc407b2cf657d0f ]

Sometimes the TX queue may be empty and we could possible
dequeue a NULL pointer, crash the kernel. If the skb is NULL
then there is nothing to do, just leave the ISR.

And the TX queue should not be empty here, so print an error
to see if there is anything wrong for DMA ring.

Fixes: e3037485c68e ("rtw88: new Realtek 802.11ac driver")
Signed-off-by: Yan-Hsuan Chuang <yhchuang@realtek.com>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/net/wireless/realtek/rtw88/pci.c