]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
btrfs: deal with errors when checking if a dir entry exists during log replay
authorFilipe Manana <fdmanana@suse.com>
Fri, 1 Oct 2021 12:52:30 +0000 (13:52 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 27 Oct 2021 07:54:29 +0000 (09:54 +0200)
commit044fa2afd67692a6385367e0e937cc396503b429
treed601c185808690ea20cc459f216b7aa450af9a08
parentd49a293b946d5291375d64ff1cbee5661c1e3f03
btrfs: deal with errors when checking if a dir entry exists during log replay

[ Upstream commit 77a5b9e3d14cbce49ceed2766b2003c034c066dc ]

Currently inode_in_dir() ignores errors returned from
btrfs_lookup_dir_index_item() and from btrfs_lookup_dir_item(), treating
any errors as if the directory entry does not exists in the fs/subvolume
tree, which is obviously not correct, as we can get errors such as -EIO
when reading extent buffers while searching the fs/subvolume's tree.

Fix that by making inode_in_dir() return the errors and making its only
caller, add_inode_ref(), deal with returned errors as well.

Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
fs/btrfs/tree-log.c