]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
fs/cachefiles: Remove wait_bit_key layout dependency
authorMatthew Wilcox (Oracle) <willy@infradead.org>
Sat, 20 Mar 2021 05:40:38 +0000 (05:40 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 30 Mar 2021 12:30:30 +0000 (14:30 +0200)
commit05f618b34885717c2e56aeeafc50bcefb34778b0
treed1873adb771bbd2202352cc8f5e57c7beb36285c
parente5f5af036526d802a83decc68255f9f803af03cc
fs/cachefiles: Remove wait_bit_key layout dependency

commit 39f985c8f667c80a3d1eb19d31138032fa36b09e upstream.

Cachefiles was relying on wait_page_key and wait_bit_key being the
same layout, which is fragile.  Now that wait_page_key is exposed in
the pagemap.h header, we can remove that fragility

A comment on the need to maintain structure layout equivalence was added by
Linus[1] and that is no longer applicable.

Fixes: 62906027091f ("mm: add PageWaiters indicating tasks are waiting for a page bit")
Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: David Howells <dhowells@redhat.com>
Tested-by: kafs-testing@auristor.com
cc: linux-cachefs@redhat.com
cc: linux-mm@kvack.org
Link: https://lore.kernel.org/r/20210320054104.1300774-2-willy@infradead.org/
Link: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=3510ca20ece0150af6b10c77a74ff1b5c198e3e2
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
fs/cachefiles/rdwr.c
include/linux/pagemap.h