]> git.ipfire.org Git - thirdparty/postgresql.git/commit
pg_upgrade: check for inconsistencies in not-null constraints w/inheritance
authorÁlvaro Herrera <alvherre@kurilemu.de>
Fri, 4 Jul 2025 16:05:43 +0000 (18:05 +0200)
committerÁlvaro Herrera <alvherre@kurilemu.de>
Fri, 4 Jul 2025 16:05:43 +0000 (18:05 +0200)
commit07da2985d6bf685c4417b3738babbcac109a4a44
tree261b1f0127e9dc3f280e061bee52249d1dbe3159
parent29a4b63c6bc83a7c21e3ccd0f484eee9a91be7d8
pg_upgrade: check for inconsistencies in not-null constraints w/inheritance

With tables defined like this,
  CREATE TABLE ip (id int PRIMARY KEY);
  CREATE TABLE ic (id int) INHERITS (ip);
  ALTER TABLE ic ALTER id DROP NOT NULL;

pg_upgrade fails during the schema restore phase due to this error:
  ERROR: column "id" in child table must be marked NOT NULL

This can only be fixed by marking the child column as NOT NULL before
the upgrade, which could take an arbitrary amount of time (because ic's
data must be scanned).  Have pg_upgrade's check mode warn if that
condition is found, so that users know what to adjust before running the
upgrade for real.

Author: Ali Akbar <the.apaan@gmail.com>
Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>
Backpatch-through: 13
Discussion: https://postgr.es/m/CACQjQLoMsE+1pyLe98pi0KvPG2jQQ94LWJ+PTiLgVRK4B=i_jg@mail.gmail.com
src/bin/pg_upgrade/check.c