]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix replay of create database records on standby
authorAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 28 Jul 2022 06:26:05 +0000 (08:26 +0200)
committerAlvaro Herrera <alvherre@alvh.no-ip.org>
Thu, 28 Jul 2022 06:26:05 +0000 (08:26 +0200)
commit084318c33a1f8aeebe492812bd1b2ed0dbafe645
tree9f7a335f34dee31f7fd4c6898aec25def3e67dcb
parent7bdbbb87340f4cb9f262320a28be8f87d4c38308
Fix replay of create database records on standby

Crash recovery on standby may encounter missing directories
when replaying database-creation WAL records.  Prior to this
patch, the standby would fail to recover in such a case;
however, the directories could be legitimately missing.
Consider the following sequence of commands:

    CREATE DATABASE
    DROP DATABASE
    DROP TABLESPACE

If, after replaying the last WAL record and removing the
tablespace directory, the standby crashes and has to replay the
create database record again, crash recovery must be able to continue.

A fix for this problem was already attempted in 49d9cfc68bf4, but it
was reverted because of design issues.  This new version is based
on Robert Haas' proposal: any missing tablespaces are created
during recovery before reaching consistency.  Tablespaces
are created as real directories, and should be deleted
by later replay.  CheckRecoveryConsistency ensures
they have disappeared.

The problems detected by this new code are reported as PANIC,
except when allow_in_place_tablespaces is set to ON, in which
case they are WARNING.  Apart from making tests possible, this
gives users an escape hatch in case things don't go as planned.

Author: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Author: Asim R Praveen <apraveen@pivotal.io>
Author: Paul Guo <paulguo@gmail.com>
Reviewed-by: Anastasia Lubennikova <lubennikovaav@gmail.com> (older versions)
Reviewed-by: Fujii Masao <masao.fujii@oss.nttdata.com> (older versions)
Reviewed-by: Michaƫl Paquier <michael@paquier.xyz>
Diagnosed-by: Paul Guo <paulguo@gmail.com>
Discussion: https://postgr.es/m/CAEET0ZGx9AvioViLf7nbR_8tH9-=27DN5xWJ2P9-ROH16e4JUA@mail.gmail.com
src/backend/access/transam/xlog.c
src/backend/commands/dbcommands.c
src/backend/commands/tablespace.c
src/test/recovery/t/033_replay_tsp_drops.pl [new file with mode: 0644]