]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
watchdog: sp805: fix restart handler
authorMichael Walle <michael@walle.cc>
Fri, 27 Mar 2020 16:24:50 +0000 (17:24 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 23 Apr 2020 08:30:12 +0000 (10:30 +0200)
commit097852a187d8ceeade75454407fa897c9b648eae
tree37455fe6a00c7182188dff6fd1f08bbed38faf2f
parenta6375c9877a81896837c79877fef874bc8a2023b
watchdog: sp805: fix restart handler

commit ea104a9e4d3e9ebc26fb78dac35585b142ee288b upstream.

The restart handler is missing two things, first, the registers
has to be unlocked and second there is no synchronization for the
write_relaxed() calls.

This was tested on a custom board with the NXP LS1028A SoC.

Fixes: 6c5c0d48b686c ("watchdog: sp805: add restart handler")
Signed-off-by: Michael Walle <michael@walle.cc>
Reviewed-by: Guenter Roeck <linux@roeck-us.net>
Link: https://lore.kernel.org/r/20200327162450.28506-1-michael@walle.cc
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Wim Van Sebroeck <wim@linux-watchdog.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/watchdog/sp805_wdt.c