]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
rcutorture: Fix cleanup path for invalid torture_type strings
authorPaul E. McKenney <paulmck@linux.ibm.com>
Thu, 21 Mar 2019 16:27:28 +0000 (09:27 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 31 May 2019 13:48:30 +0000 (06:48 -0700)
commit0b447e75c2c35a8509aba93e1adc0bfedafb53b6
treefa3382e2a2d892e7e18089fc3c6c5c555cf501e0
parent9305bac20f84c93ddcbe24f2f99e8a481c77841e
rcutorture: Fix cleanup path for invalid torture_type strings

[ Upstream commit b813afae7ab6a5e91b4e16cc567331d9c2ae1f04 ]

If the specified rcutorture.torture_type is not in the rcu_torture_init()
function's torture_ops[] array, rcutorture prints some console messages
and then invokes rcu_torture_cleanup() to set state so that a future
torture test can run.  However, rcu_torture_cleanup() also attempts to
end the test that didn't actually start, and in doing so relies on the
value of cur_ops, a value that is not particularly relevant in this case.
This can result in confusing output or even follow-on failures due to
attempts to use facilities that have not been properly initialized.

This commit therefore sets the value of cur_ops to NULL in this case
and inserts a check near the beginning of rcu_torture_cleanup(),
thus avoiding relying on an irrelevant cur_ops value.

Reported-by: kernel test robot <rong.a.chen@intel.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.ibm.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
kernel/rcu/rcutorture.c