]> git.ipfire.org Git - thirdparty/bind9.git/commit
Only log bumped signed serial after a successful secure zone update
authorMichał Kępień <michal@isc.org>
Fri, 16 Mar 2018 23:12:21 +0000 (00:12 +0100)
committerEvan Hunt <each@isc.org>
Wed, 25 Apr 2018 19:19:30 +0000 (12:19 -0700)
commit0d4750a8e98a160ea29a5ef70b05df24896c34c8
tree3291fc9e5a713eedafc24c00072b9a564b5f87bf
parenteaf4b8b4fc5783dd4eb1634c5c6a6d5c9aedbe8d
Only log bumped signed serial after a successful secure zone update

If a raw zone is modified, but the dns_update_signaturesinc() call in
receive_secure_serial() fails, the corresponding secure zone's database
will not be modified, even though by that time a message containing the
bumped signed serial will already have been logged.  This creates
confusion, because a different secure zone version will be served than
the one announced in the logs.  Move the relevant dns_zone_log() call so
that it is only performed if the secure zone's database is modified.

(cherry picked from commit cfbc8e264d5a276fda2d1c0b15a4725cc293ba65)
(cherry picked from commit cdc7ab42b111a4e6aaaac19e86069d996ea11002)
(cherry picked from commit c042ec70d2aa433cc1fdd7f65c06febf3dd2cd82)
lib/dns/zone.c