]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
drm/colorop: Preserve bypass value in duplicate_state()
authorChaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Tue, 10 Mar 2026 11:32:37 +0000 (17:02 +0530)
committerSuraj Kandpal <suraj.kandpal@intel.com>
Mon, 16 Mar 2026 03:03:05 +0000 (08:33 +0530)
commit0d9710aeb6959ae244f255986187562fa50504b9
treee5c48eb7f567eb6b824447a03afbdca7599a4628
parent79ac1c945ab885369a840da014ebc6fcde8e2ae2
drm/colorop: Preserve bypass value in duplicate_state()

__drm_atomic_helper_colorop_duplicate_state() unconditionally
sets state->bypass = true after copying the existing state.

This override causes the new atomic state to no longer reflect
the currently committed hardware state. Since the bypass property
directly controls whether the colorop is active in hardware,
resetting it to true can inadvertently disable an active colorop
during a subsequent commit, particularly for internal driver commits
where userspace does not touch the property.

Drop the unconditional assignment and preserve the duplicated
bypass value.

Fixes: 8c5ea1745f4c ("drm/colorop: Add BYPASS property")
Cc: <stable@vger.kernel.org> #v6.19+
Reviewed-by: Uma Shankar <uma.shankar@intel.com>
Signed-off-by: Chaitanya Kumar Borah <chaitanya.kumar.borah@intel.com>
Reviewed-by: Harry Wentland <harry.wentland@amd.com>
Signed-off-by: Suraj Kandpal <suraj.kandpal@intel.com>
Link: https://patch.msgid.link/20260310113238.3495981-2-chaitanya.kumar.borah@intel.com
drivers/gpu/drm/drm_colorop.c