]> git.ipfire.org Git - thirdparty/postgresql.git/commit
Fix an oversight in 3f28b2fcac.
authorAmit Kapila <akapila@postgresql.org>
Wed, 23 Apr 2025 05:05:54 +0000 (10:35 +0530)
committerAmit Kapila <akapila@postgresql.org>
Wed, 23 Apr 2025 05:05:54 +0000 (10:35 +0530)
commit0de091a4b585bfb3ffa2dc1f6e7465db1d0b3eba
treeaa4d1a7f0c552ed2eb280c5757db0bd98264c734
parente9ab8677bfc581bdfbcc1e5d286d7d6269741b90
Fix an oversight in 3f28b2fcac.

Commit 3f28b2fcac tried to ensure that the replication origin shouldn't be
advanced in case of an ERROR in the apply worker, so that it can request
the same data again after restart. However, it is possible that an ERROR
was caught and handled by a (say PL/pgSQL) function, and  the apply worker
continues to apply further changes, in which case, we shouldn't reset the
replication origin.

Ensure to reset the origin only when the apply worker exits after an
ERROR.

Commit 3f28b2fcac added new function geterrlevel, which we removed in HEAD
as part of this commit, but kept it in backbranches to avoid breaking any
applications. A separate case can be made to have such a function even for
HEAD.

Reported-by: Shawn McCoy <shawn.the.mccoy@gmail.com>
Author: Hayato Kuroda <kuroda.hayato@fujitsu.com>
Reviewed-by: Masahiko Sawada <sawada.mshk@gmail.com>
Reviewed-by: vignesh C <vignesh21@gmail.com>
Reviewed-by: Amit Kapila <amit.kapila16@gmail.com>
Backpatch-through: 16, where it was introduced
Discussion: https://postgr.es/m/CALsgZNCGARa2mcYNVTSj9uoPcJo-tPuWUGECReKpNgTpo31_Pw@mail.gmail.com
src/backend/replication/logical/worker.c
src/test/subscription/t/100_bugs.pl