]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
ir-core: fix gcc-7 warning on bool arithmetic
authorArnd Bergmann <arnd@arndb.de>
Thu, 11 May 2017 11:46:44 +0000 (08:46 -0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 27 Jul 2017 22:06:02 +0000 (15:06 -0700)
commit0ff1117c08c296aec084f9e1329f7a4ec2537ec7
treed7a116b18cdfe301fab7439806aff73f8ad7f634
parent83863589806d00fd7b5936dcee1a897088452275
ir-core: fix gcc-7 warning on bool arithmetic

commit bd7e31bbade02bc1e92aa00d5cf2cee2da66838a upstream.

gcc-7 suggests that an expression using a bitwise not and a bitmask
on a 'bool' variable is better written using boolean logic:

drivers/media/rc/imon.c: In function 'imon_incoming_scancode':
drivers/media/rc/imon.c:1725:22: error: '~' on a boolean expression [-Werror=bool-operation]
    ictx->pad_mouse = ~(ictx->pad_mouse) & 0x1;
                      ^
drivers/media/rc/imon.c:1725:22: note: did you mean to use logical not?

I agree.

Fixes: 21677cfc562a ("V4L/DVB: ir-core: add imon driver")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/rc/imon.c