]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: iris: Fix fps calculation
authorRicardo Ribalda <ribalda@chromium.org>
Tue, 23 Dec 2025 10:02:58 +0000 (10:02 +0000)
committerSasha Levin <sashal@kernel.org>
Wed, 4 Mar 2026 12:21:09 +0000 (07:21 -0500)
commit101f2b3cd0b6155b144c3d2ff90228802adc35f0
tree9b6b17490b465b8b8a0d39807a088997716c8f2b
parent0cd7ca8e96034908ab46fe997c2dd987690f7f15
media: iris: Fix fps calculation

[ Upstream commit 71fe80364a6584f404556ac9a6a4aca4ab80fb5b ]

iris_venc_s_param() uses do_div to divide two 64 bits operators, this is
wrong. Luckily for us, both of the operators fit in 32 bits, so we can use
a normal division.

Now that we are at it, mark the fps smaller than 1 as invalid, the code
does not seem to handle them properly.

The following cocci warning is fixed with this patch:
./platform/qcom/iris/iris_venc.c:378:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead

Fixes: 4ff586ff28e3 ("media: iris: Add support for G/S_PARM for encoder video device")
Reviewed-by: Dikshita Agarwal <dikshita.agarwal@oss.qualcomm.com>
Cc: stable@vger.kernel.org
Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
Signed-off-by: Bryan O'Donoghue <bod@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil+cisco@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/media/platform/qcom/iris/iris_venc.c