]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
net: ethoc: Fix early error paths
authorFlorian Fainelli <f.fainelli@gmail.com>
Tue, 12 Jul 2016 23:04:35 +0000 (16:04 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 May 2020 08:26:33 +0000 (10:26 +0200)
commit10be8a1102c681b67e9e72b9fb8a505d62df93df
tree4a9f825290c70004f0d828fb589373c4f1f6f508
parentb1f88cb2ca8526e77e482c80a5c5bf6ab041cbe1
net: ethoc: Fix early error paths

commit 386512d18b268c6182903239f9f3390f03ce4c7b upstream.

In case any operation fails before we can successfully go the point
where we would register a MDIO bus, we would be going to an error label
which involves unregistering then freeing this yet to be created MDIO
bus. Update all error paths to go to label free which is the only one
valid until either the clock is enabled, or the MDIO bus is allocated
and registered. This fixes kernel oops observed while trying to
dereference the MDIO bus structure which is not yet allocated.

Fixes: a1702857724f ("net: Add support for the OpenCores 10/100 Mbps Ethernet MAC.")
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/ethoc.c