]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tracing/x86/xen: Remove zero data size trace events trace_xen_mmu_flush_tlb{_all}
authorSteven Rostedt (VMware) <rostedt@goodmis.org>
Wed, 9 May 2018 18:36:09 +0000 (14:36 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 26 May 2018 06:48:54 +0000 (08:48 +0200)
commit111cb9f5df8a649cd0e57bbacf8d5254a2a8c712
tree98cc8aef1f8aeffb28002c02c028ca9973e79348
parentf5a80c5d9ca98045bae32ef29a9ab031066047ba
tracing/x86/xen: Remove zero data size trace events trace_xen_mmu_flush_tlb{_all}

commit 45dd9b0666a162f8e4be76096716670cf1741f0e upstream.

Doing an audit of trace events, I discovered two trace events in the xen
subsystem that use a hack to create zero data size trace events. This is not
what trace events are for. Trace events add memory footprint overhead, and
if all you need to do is see if a function is hit or not, simply make that
function noinline and use function tracer filtering.

Worse yet, the hack used was:

 __array(char, x, 0)

Which creates a static string of zero in length. There's assumptions about
such constructs in ftrace that this is a dynamic string that is nul
terminated. This is not the case with these tracepoints and can cause
problems in various parts of ftrace.

Nuke the trace events!

Link: http://lkml.kernel.org/r/20180509144605.5a220327@gandalf.local.home
Cc: stable@vger.kernel.org
Fixes: 95a7d76897c1e ("xen/mmu: Use Xen specific TLB flush instead of the generic one.")
Reviewed-by: Juergen Gross <jgross@suse.com>
Signed-off-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
arch/x86/xen/mmu.c
include/trace/events/xen.h