]> git.ipfire.org Git - thirdparty/samba.git/commit
s4:rpc_server: Properly initialize ‘lsa_CreateTrustedDomainEx2’ structure (CID 1499404)
authorJoseph Sutton <josephsutton@catalyst.net.nz>
Mon, 30 Oct 2023 23:14:27 +0000 (12:14 +1300)
committerAndrew Bartlett <abartlet@samba.org>
Thu, 2 Nov 2023 04:04:49 +0000 (04:04 +0000)
commit1372ef0ef46f6eee615c2fffd5286e96aeb8417a
treec86ec1a1b04444c1a26131bd5ce43a3ae9acd8d7
parentfa25793ebff92bee2bb1bf0b437b5f705ee8a1dc
s4:rpc_server: Properly initialize ‘lsa_CreateTrustedDomainEx2’ structure (CID 1499404)

dcesrv_lsa_CreateTrustedDomain_base() invokes DCESRV_PULL_HANDLE(),
which invokes DCESRV_PULL_HANDLE_RETVAL(), which invokes
DCESRV_CHECK_HANDLE(), which might invoke DCESRV_FAULT(), which accesses
r2.out.result, which is uninitialized — invoking undefined behaviour.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Thu Nov  2 04:04:49 UTC 2023 on atb-devel-224
source4/rpc_server/lsa/dcesrv_lsa.c