]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
staging/rts5208: fix incorrect shift to extract upper nybble
authorColin Ian King <colin.king@canonical.com>
Fri, 18 Aug 2017 13:34:16 +0000 (14:34 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 13 Sep 2017 21:03:46 +0000 (14:03 -0700)
commit158333ad9be61dd5fa75e5566665dc0eee892a2e
treee9609fef5b5857029748fa9cf32d1cf5a5e0fbca
parentd512a57678a695275bda7f218d4efccd4f89948c
staging/rts5208: fix incorrect shift to extract upper nybble

commit 34ff1bf4920471cff66775dc39537b15c5f0feff upstream.

The mask of sns_key_info1 suggests the upper nybble is being extracted
however the following shift of 8 bits is too large and always results in
0.  Fix this by shifting only by 4 bits to correctly get the upper nybble.

Detected by CoverityScan, CID#142891 ("Operands don't affect result")

Fixes: fa590c222fba ("staging: rts5208: add support for rts5208 and rts5288")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rts5208/rtsx_scsi.c