]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
tty: max310x: Fix external crystal register setup
authorJoe Burmeister <joe.burmeister@devtank.co.uk>
Mon, 13 May 2019 10:23:57 +0000 (11:23 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 9 Jun 2019 07:16:13 +0000 (09:16 +0200)
commit15ff2c6a8838bef403adc538f5a2984e848d1afd
tree6c2c6951ee9dfc98d8f14e51f81dda37662a13af
parent5f436d8d774d87667a90c0611764867ba92d74aa
tty: max310x: Fix external crystal register setup

commit 5d24f455c182d5116dd5db8e1dc501115ecc9c2c upstream.

The datasheet states:

  Bit 4: ClockEnSet the ClockEn bit high to enable an external clocking
(crystal or clock generator at XIN). Set the ClockEn bit to 0 to disable
clocking
  Bit 1: CrystalEnSet the CrystalEn bit high to enable the crystal
oscillator. When using an external clock source at XIN, CrystalEn must
be set low.

The bit 4, MAX310X_CLKSRC_EXTCLK_BIT, should be set and was not.

This was required to make the MAX3107 with an external crystal on our
board able to send or receive data.

Signed-off-by: Joe Burmeister <joe.burmeister@devtank.co.uk>
Cc: stable <stable@vger.kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/max310x.c