]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
irqchip/irq-realtek-rtl: Add/simplify register helpers
authorMarkus Stockhausen <markus.stockhausen@gmx.de>
Thu, 4 Jun 2026 18:25:05 +0000 (20:25 +0200)
committerThomas Gleixner <tglx@kernel.org>
Fri, 5 Jun 2026 09:35:10 +0000 (11:35 +0200)
commit167883f75f83088a2b32c85ce5e3d0cd1cef157b
treea8291c7d9b1f56d4c0d703019d664eda0f841bc6
parent71619266e0a272ef5ef137a661e8e3f1711c2aba
irqchip/irq-realtek-rtl: Add/simplify register helpers

The Realtek interrupt controller has two important registers that are used
by the driver in several places

 - GIMR: global interrupt mask register
 - IRR: Interrupt routing registers

The usage of these registers is very inconsistent. GIMR is addressed
directly while IRR has a helper that needs a macro as an input. Harmonize
this by providing consistent helpers that improve code readability.

The callers of these helpers use classic lock/unlock functions and
sometimes use the wrong locking helper. E.g. irqsave variants are used in
mask/unmask although not needed. Adapt and fix the surrounding call
locations.

Signed-off-by: Markus Stockhausen <markus.stockhausen@gmx.de>
Signed-off-by: Thomas Gleixner <tglx@kernel.org>
Link: https://patch.msgid.link/20260604182506.1113440-2-markus.stockhausen@gmx.de
drivers/irqchip/irq-realtek-rtl.c