]> git.ipfire.org Git - thirdparty/rsync.git/commit
testsuite: verify destination content/listings in daemon tests
authorAndrew Tridgell <andrew@tridgell.net>
Sun, 24 May 2026 22:12:03 +0000 (08:12 +1000)
committerAndrew Tridgell <andrew@tridgell.net>
Mon, 25 May 2026 21:43:00 +0000 (07:43 +1000)
commit1687230672ad4ad23f63d76d6d7a2fdc520de6ed
tree52571d81d75f8c779997ff1dd35b560eb31843af
parentf196279c2916cabebea9aad1354fed78ffb127cf
testsuite: verify destination content/listings in daemon tests

These daemon tests confirmed refusals/exclusions but accepted the allowed
transfers on exit status alone, so a transfer that exited cleanly while moving
nothing would pass:

  daemon-refuse  allowed() imported verify_dirs but never called it; now it
                 confirms the allowed push/pull actually populated the dest.
  daemon-filter  pull()/the incoming push ignored their exit status, and the
                 outgoing-chmod loop iterated only files that exist -- a
                 zero-file pull passed vacuously. Check the codes and require
                 at least one file to have been mode-checked.
  daemon         run_and_check's unused `expected` param is dropped; the
                 hidden-module and glob listings now compare the exact set of
                 listed paths (catching a leaked extra path), replacing the
                 per-path containment check and the dead normalise() helper
                 whose regex never matched the -r listing format anyway.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
testsuite/daemon-filter_test.py
testsuite/daemon-refuse_test.py
testsuite/daemon_test.py