]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
sunrpc: fix cache_request leak in cache_release
authorJeff Layton <jlayton@kernel.org>
Mon, 23 Feb 2026 17:09:58 +0000 (12:09 -0500)
committerChuck Lever <chuck.lever@oracle.com>
Sat, 14 Mar 2026 15:37:13 +0000 (11:37 -0400)
commit17ad31b3a43b72aec3a3d83605891e1397d0d065
tree0a99b44edf2393da98b077808fdad7dc85f5be9b
parente7fcf179b82d3a3730fd8615da01b087cc654d0b
sunrpc: fix cache_request leak in cache_release

When a reader's file descriptor is closed while in the middle of reading
a cache_request (rp->offset != 0), cache_release() decrements the
request's readers count but never checks whether it should free the
request.

In cache_read(), when readers drops to 0 and CACHE_PENDING is clear, the
cache_request is removed from the queue and freed along with its buffer
and cache_head reference. cache_release() lacks this cleanup.

The only other path that frees requests with readers == 0 is
cache_dequeue(), but it runs only when CACHE_PENDING transitions from
set to clear. If that transition already happened while readers was
still non-zero, cache_dequeue() will have skipped the request, and no
subsequent call will clean it up.

Add the same cleanup logic from cache_read() to cache_release(): after
decrementing readers, check if it reached 0 with CACHE_PENDING clear,
and if so, dequeue and free the cache_request.

Reported-by: NeilBrown <neilb@ownmail.net>
Fixes: 1da177e4c3f4 ("Linux-2.6.12-rc2")
Cc: stable@kernel.org
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
net/sunrpc/cache.c