]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
mvpp2: use correct size for memset
authorArnd Bergmann <arnd@arndb.de>
Thu, 24 Nov 2016 16:28:12 +0000 (17:28 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 10 May 2020 08:26:32 +0000 (10:26 +0200)
commit183ed2b1df13c38955a9e9011835e1213de2ed9a
treef2178ffd7c22cc61ded8c1f42c04120c552585b3
parente3ca76fc5cd6c5833e2ae609f9d97dc2ac9298aa
mvpp2: use correct size for memset

commit e8f967c3d88489fc1562a31d4e44d905ac1d3aff upstream.

gcc-7 detects a short memset in mvpp2, introduced in the original
merge of the driver:

drivers/net/ethernet/marvell/mvpp2.c: In function 'mvpp2_cls_init':
drivers/net/ethernet/marvell/mvpp2.c:3296:2: error: 'memset' used with length equal to number of elements without multiplication by element size [-Werror=memset-elt-size]

The result seems to be that we write uninitialized data into the
flow table registers, although we did not get any warning about
that uninitialized data usage.

Using sizeof() lets us initialize then entire array instead.

Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network unit")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/net/ethernet/marvell/mvpp2.c