]> git.ipfire.org Git - thirdparty/libvirt.git/commit
hyperv: Introduce and export 'facility' variable.
authorMichal Privoznik <mprivozn@redhat.com>
Thu, 19 Dec 2024 10:02:59 +0000 (11:02 +0100)
committerMichal Privoznik <mprivozn@redhat.com>
Mon, 6 Jan 2025 13:21:18 +0000 (14:21 +0100)
commit18b8e6d3cc443003e4aaa1226ca866d5040d5cd6
treebb75ad544c659ebc7e41251c5bea41ecade66668
parenta91b22ffc6732c9354e8ed858e6d28478c5ea956
hyperv: Introduce and export 'facility' variable.

In its upstream commit [1] openwsman dropped 'facility' variable
which is documented as:

 * all processes that use the libu must define a "facility" variable somewhere
 * to satisfy this external linkage reference.
 *
 * Such variable will be used as the syslog(3) facility argument.

Well, prior to that commit, openwsman itself declared the
variable (and set it to LOG_DAEMON). Now it's up to us.

Yeah, the variable naming is terrible and also I we are not using
libu directly, but apparently libwsman.so requires it anyway:

  $ objdump -T /usr/lib64/libwsman.so | grep facility
  0000000000000000      D  *UND*  0000000000000000  Base        facility

1: https://github.com/Openwsman/openwsman/commit/d72c51f21b9c85a773b7955ac587d2d3cea982c1
Signed-off-by: Michal Privoznik <mprivozn@redhat.com>
Reviewed-by: Martin Kletzander <mkletzan@redhat.com>
src/hyperv/hyperv_wmi.c
src/libvirt_hyperv.syms [new file with mode: 0644]
src/meson.build