]> git.ipfire.org Git - thirdparty/kernel/linux.git/commit
ASoC: cs35l56: Fix flushing of IRQ work in cs35l56_sdw_remove()
authorRichard Fitzgerald <rf@opensource.cirrus.com>
Thu, 21 May 2026 12:30:57 +0000 (13:30 +0100)
committerMark Brown <broonie@kernel.org>
Thu, 21 May 2026 13:13:06 +0000 (14:13 +0100)
commit18e7bd9f2446664053f8c34b72abd4606d22d858
tree2bf423d1a10bef8404f953d322acf59fc323254c
parent2b98b990404700297af4ef1ca00041a7cefddaa0
ASoC: cs35l56: Fix flushing of IRQ work in cs35l56_sdw_remove()

Use flush_work() instead of cancel_work_sync() to terminate pending IRQ
work in cs35l56_sdw_remove(). And flush_work() again after masking the
interrupts to flush any queueing that was racing with the masking. This is
the same sequence as cs35l56_sdw_system_suspend().

cs35l56_sdw_interrupt() takes the pm_runtime to prevent the bus powering-
down before the interrupt status can be read and handled. The work releases
this pm_runtime. So cancelling it, instead of flushing, could leave an
unbalanced pm_runtime.

Signed-off-by: Richard Fitzgerald <rf@opensource.cirrus.com>
Fixes: e49611252900 ("ASoC: cs35l56: Add driver for Cirrus Logic CS35L56")
Link: https://patch.msgid.link/20260521123057.988732-1-rf@opensource.cirrus.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/cs35l56-sdw.c