]> git.ipfire.org Git - thirdparty/bind9.git/commit
Use memory_order_acq_rel in isc_refcount_decrement.
authorMark Andrews <marka@isc.org>
Tue, 25 Aug 2020 12:42:27 +0000 (22:42 +1000)
committerMark Andrews <marka@isc.org>
Tue, 1 Sep 2020 12:24:52 +0000 (22:24 +1000)
commit1af9cf78bddf265932e335ebcfcd6c24816b049a
tree50efb5080c951b418273988fa717dee6160bdeb1
parent4f949e5c5bf94ea8c528be03c2af7f083c04a88d
Use memory_order_acq_rel in isc_refcount_decrement.

While

if (isc_refcount_decrement() == 1) { // memory_order_release
isc_refcount_destroy(); // memory_order_acquire
...
}

is theoretically the most efficent in practice, using
memory_order_acq_rel produces the same code on x86_64 and doesn't
trigger tsan data races (which use a idealistic model) if
isc_refcount_destroy() is not called immediately.  In fact
isc_refcount_destroy() could be removed if we didn't want
to check for the count being 0 when isc_refcount_destroy() is
called.

https://stackoverflow.com/questions/49112732/memory-order-in-shared-pointer-destructor
(cherry picked from commit 6278899a3849b7ee46b6460dff93e555e77d99a2)
lib/isc/include/isc/atomic.h
lib/isc/include/isc/refcount.h