]> git.ipfire.org Git - thirdparty/kernel/stable.git/commit
media: gspca/sq905: fix control-request direction
authorJohan Hovold <johan@kernel.org>
Fri, 21 May 2021 13:28:39 +0000 (15:28 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Mon, 19 Jul 2021 06:53:18 +0000 (08:53 +0200)
commit1c44f2e25d8e121ed579efefaf4f9b72b71e1f04
tree52bfaa7cffd18c7d15fe6b3a374c39778201d8d9
parent0edd6759167295ea9969e89283b81017b4c688aa
media: gspca/sq905: fix control-request direction

commit 53ae298fde7adcc4b1432bce2dbdf8dac54dfa72 upstream.

The direction of the pipe argument must match the request-type direction
bit or control requests may fail depending on the host-controller-driver
implementation.

Fix the USB_REQ_SYNCH_FRAME request which erroneously used
usb_sndctrlpipe().

Fixes: 27d35fc3fb06 ("V4L/DVB (10639): gspca - sq905: New subdriver.")
Cc: stable@vger.kernel.org # 2.6.30
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/media/usb/gspca/sq905.c